fix: Correct logger for OtpSession #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results: Windows 2 files 2 suites 10s ⏱️ Results for commit e956c1c. |
Test Results: Ubuntu 2 files 2 suites 15s ⏱️ Results for commit e956c1c. |
Minimum allowed line rate is |
Test Results: MacOS 2 files 2 suites 10s ⏱️ Results for commit e956c1c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes several updates to the YubiKey SDK, focusing on improving code clarity and correctness. The changes include removing unused imports, modernizing syntax, and fixing a logging issue in the
OtpSessionclass.Code cleanup:
Yubico.YubiKey/src/Yubico/YubiKey/Oath/OathSession.cs: Removed unused imports, includingMicrosoft.Extensions.LoggingandYubico.YubiKey.InterIndustry.Commands, to streamline the file.Syntax modernization:
Yubico.YubiKey/src/Yubico/YubiKey/Oath/OathSession.cs: Updated the conditional check to use the modernis notsyntax for better readability and alignment with C# 9.0 features.Bug fix:
Yubico.YubiKey/src/Yubico/YubiKey/Otp/OtpSession.cs: Corrected the logger initialization to useOtpSessioninstead ofOathSession, ensuring accurate logging context for the OTP session.